# Re: [PATCH] Set OLD_ICONV on Cygwin.

5 messages from 2007-12-04 to 2007-12-04. Participants: Andreas Ericsson, Pascal Obry, Junio C Hamano.
Thread: https://gitlist.dev/t/11129

## Pascal Obry, 2007-12-04 13:39

Subject: Re: [PATCH] Set OLD_ICONV on Cygwin.
Message-ID: <21977191.137171196775591804.JavaMail.www@wwinf1621>
URL: https://gitlist.dev/e/21977191.137171196775591804.JavaMail.www%40wwinf1621

```

Andreas Ericsson wrote:
> Only one, insofar as I can see; You didn't CC Junio. He probably missed it.

Hum, I don't think this is a requirement. At least nothing is said about
CCing Junio on the Git Web site.

Anyway, now Junio is CCed :)

Pascal.

```

## Andreas Ericsson, 2007-12-04 13:43

Subject: Re: [PATCH] Set OLD_ICONV on Cygwin.
Message-ID: <4755597B.9050709@op5.se>
URL: https://gitlist.dev/e/4755597B.9050709%40op5.se
In-Reply-To: <21977191.137171196775591804.JavaMail.www@wwinf1621>

```
Pascal Obry wrote:
> Andreas Ericsson wrote:
>> Only one, insofar as I can see; You didn't CC Junio. He probably missed it.
> 
> Hum, I don't think this is a requirement. At least nothing is said about
> CCing Junio on the Git Web site.
> 

It's not a requirement, but he won't act on things he doesn't see, and CC'ing
him directly is the recommended way of getting his attention. Most people do
so for patches that aren't directly related to a sub-part of git primarily
maintained by someone else (Shawn O. Pearce for git-gui, Eric Wong for git-svn,
etc., etc.)

> Anyway, now Junio is CCed :)
> 

Nice. If my suspicions are correct and he missed your patch the first time
around, you should probably resend it though.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

```

## Junio C Hamano, 2007-12-04 17:54

Subject: Re: [PATCH] Set OLD_ICONV on Cygwin.
Message-ID: <7v63ze5osn.fsf@gitster.siamese.dyndns.org>
URL: https://gitlist.dev/e/7v63ze5osn.fsf%40gitster.siamese.dyndns.org
In-Reply-To: <4755597B.9050709@op5.se>

```
Andreas Ericsson <ae@op5.se> writes:

> Nice. If my suspicions are correct and he missed your patch the first time
> around, you should probably resend it though.

I still have it in my mailbox.

I saw the patch but saw nobody else said about the patch being helpful
to his installation, nor more importantly, "Good, this won't hurt for me
who run a different vintage of Cygwin", and I was waiting for such
confirmations.

Then nobody responded, so I forgot.

That was what happened the first time Pascal's patch was posted.

```

## Junio C Hamano, 2007-12-04 21:59

Subject: Re: [PATCH] Set OLD_ICONV on Cygwin.
Message-ID: <7vaboq3yuy.fsf@gitster.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vaboq3yuy.fsf%40gitster.siamese.dyndns.org
In-Reply-To: <7v63ze5osn.fsf@gitster.siamese.dyndns.org>

```
Junio C Hamano <gitster@pobox.com> writes:

> Andreas Ericsson <ae@op5.se> writes:
>
>> Nice. If my suspicions are correct and he missed your patch the first time
>> around, you should probably resend it though.
>
> I still have it in my mailbox.
>
> I saw the patch but saw nobody else said about the patch being helpful
> to his installation, nor more importantly, "Good, this won't hurt for me
> who run a different vintage of Cygwin", and I was waiting for such
> confirmations.
>
> Then nobody responded, so I forgot.
>
> That was what happened the first time Pascal's patch was posted.

I think the patch is fine; I just checked with my copy of Cygwin that I
haven't fired for some time (it was a pain waiting for it to update to
the latest set of git sources).

I am at work and will be busy for the rest of the afternoon, so won't be
applying it until this evening, though.

```

## Pascal Obry, 2007-12-04 22:12

Subject: Re: [PATCH] Set OLD_ICONV on Cygwin.
Message-ID: <4755D0C3.501@obry.net>
URL: https://gitlist.dev/e/4755D0C3.501%40obry.net
In-Reply-To: <7vaboq3yuy.fsf@gitster.siamese.dyndns.org>

```
Junio C Hamano a écrit :
> I am at work and will be busy for the rest of the afternoon, so won't be
> applying it until this evening, though.

Ok, thanks. No urgency with this patch anyway.

Pascal.

-- 

--|------------------------------------------------------
--| Pascal Obry                           Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--|              http://www.obry.net
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver wwwkeys.pgp.net --recv-key C1082595

```