{"thread":{"id":"11129","subject":"Re: [PATCH] Set OLD_ICONV on Cygwin.","startedAt":"2007-12-04T13:39:51Z","lastAt":"2007-12-04T22:12:19Z","messageCount":5,"participants":["Andreas Ericsson","Pascal Obry","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"61917","messageId":"21977191.137171196775591804.JavaMail.www@wwinf1621","threadId":"11129","inReplyTo":null,"subject":"Re: [PATCH] Set OLD_ICONV on Cygwin.","fromName":"Pascal Obry","fromEmail":"pascal.obry@wanadoo.fr","sentAt":"2007-12-04T13:39:51Z","receivedAt":"2007-12-04T13:39:51Z","isPatch":true,"sender":{"key":"pascal@obry.net","avatar":"https://avatars.githubusercontent.com/u/467069?v=4"},"body":"\nAndreas Ericsson wrote:\n> Only one, insofar as I can see; You didn't CC Junio. He probably missed it.\n\nHum, I don't think this is a requirement. At least nothing is said about\nCCing Junio on the Git Web site.\n\nAnyway, now Junio is CCed :)\n\nPascal.\n"},{"id":"61906","messageId":"4755597B.9050709@op5.se","threadId":"11129","inReplyTo":"21977191.137171196775591804.JavaMail.www@wwinf1621","subject":"Re: [PATCH] Set OLD_ICONV on Cygwin.","fromName":"Andreas Ericsson","fromEmail":"ae@op5.se","sentAt":"2007-12-04T13:43:23Z","receivedAt":"2007-12-04T13:43:23Z","isPatch":true,"sender":{"key":"ae@op5.se","avatar":"https://gravatar.com/avatar/426e89595c75a8f5252dd0c989e5fabe5bcac616e68557427ad9aef6b0ca342a?d=mp&s=160"},"body":"Pascal Obry wrote:\n> Andreas Ericsson wrote:\n>> Only one, insofar as I can see; You didn't CC Junio. He probably missed it.\n> \n> Hum, I don't think this is a requirement. At least nothing is said about\n> CCing Junio on the Git Web site.\n> \n\nIt's not a requirement, but he won't act on things he doesn't see, and CC'ing\nhim directly is the recommended way of getting his attention. Most people do\nso for patches that aren't directly related to a sub-part of git primarily\nmaintained by someone else (Shawn O. Pearce for git-gui, Eric Wong for git-svn,\netc., etc.)\n\n> Anyway, now Junio is CCed :)\n> \n\nNice. If my suspicions are correct and he missed your patch the first time\naround, you should probably resend it though.\n\n-- \nAndreas Ericsson andreas.ericsson@op5.se\nOP5 AB www.op5.se\nTel: +46 8-230225 Fax: +46 8-230231\n"},{"id":"61929","messageId":"7v63ze5osn.fsf@gitster.siamese.dyndns.org","threadId":"11129","inReplyTo":"4755597B.9050709@op5.se","subject":"Re: [PATCH] Set OLD_ICONV on Cygwin.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-12-04T17:54:00Z","receivedAt":"2007-12-04T17:54:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Andreas Ericsson writes:\n\n> Nice. If my suspicions are correct and he missed your patch the first time\n> around, you should probably resend it though.\n\nI still have it in my mailbox.\n\nI saw the patch but saw nobody else said about the patch being helpful\nto his installation, nor more importantly, \"Good, this won't hurt for me\nwho run a different vintage of Cygwin\", and I was waiting for such\nconfirmations.\n\nThen nobody responded, so I forgot.\n\nThat was what happened the first time Pascal's patch was posted.\n"},{"id":"61948","messageId":"7vaboq3yuy.fsf@gitster.siamese.dyndns.org","threadId":"11129","inReplyTo":"7v63ze5osn.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] Set OLD_ICONV on Cygwin.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-12-04T21:59:33Z","receivedAt":"2007-12-04T21:59:33Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano writes:\n\n> Andreas Ericsson writes:\n>\n>> Nice. If my suspicions are correct and he missed your patch the first time\n>> around, you should probably resend it though.\n>\n> I still have it in my mailbox.\n>\n> I saw the patch but saw nobody else said about the patch being helpful\n> to his installation, nor more importantly, \"Good, this won't hurt for me\n> who run a different vintage of Cygwin\", and I was waiting for such\n> confirmations.\n>\n> Then nobody responded, so I forgot.\n>\n> That was what happened the first time Pascal's patch was posted.\n\nI think the patch is fine; I just checked with my copy of Cygwin that I\nhaven't fired for some time (it was a pain waiting for it to update to\nthe latest set of git sources).\n\nI am at work and will be busy for the rest of the afternoon, so won't be\napplying it until this evening, though.\n"},{"id":"61953","messageId":"4755D0C3.501@obry.net","threadId":"11129","inReplyTo":"7vaboq3yuy.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] Set OLD_ICONV on Cygwin.","fromName":"Pascal Obry","fromEmail":"pascal@obry.net","sentAt":"2007-12-04T22:12:19Z","receivedAt":"2007-12-04T22:12:19Z","isPatch":true,"sender":{"key":"pascal@obry.net","avatar":"https://avatars.githubusercontent.com/u/467069?v=4"},"body":"Junio C Hamano a écrit :\n> I am at work and will be busy for the rest of the afternoon, so won't be\n> applying it until this evening, though.\n\nOk, thanks. No urgency with this patch anyway.\n\nPascal.\n\n-- \n\n--|------------------------------------------------------\n--| Pascal Obry Team-Ada Member\n--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE\n--|------------------------------------------------------\n--| http://www.obry.net\n--| \"The best way to travel is by means of imagination\"\n--|\n--| gpg --keyserver wwwkeys.pgp.net --recv-key C1082595\n"}]}