Re: [PATCH 14/14] MINGW: config.mak.uname: auto-detect MinGW build from compiler

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 9, 2014, 07:34 UTC
Message-ID: <xmqqzjd57l32.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20141009050318.GA17479@seldon>

Marat Radchenko <marat@slonopotamus.org> writes:

Show 15 quoted lines

> On Wed, Oct 08, 2014 at 12:26:52PM -0700, Junio C Hamano wrote:
> ...
>> What I am wondering is if it is a better solution to make it easier
>> to allow somebody who is cross compiling to express "Mr.  Makefile,
>> we know better than you and want you to do a MINGW build for us
>> without checking with `uname -?` yourself", i.e.
>> 
>> 	$ make uname_O=MINGW uname_S=MINGW
>> 
>> which would hopefully allow cross-compilation into other
>> environments, not just MINGW.
>
> So, do you really want this patch to be changed from 5-liner into
> a full-blow system detection rewrite based on `cc -dumpmachine`
> instead of `uname`?

No, and I do not quite see why you even need to look at -dumbmachine output when your goal is to make this command line

>> 	$ make uname_O=MINGW uname_S=MINGW

work sensibly.  Wouldn't it be more like a series of

	ifndef uname_O
        uname_O := $(shell uname -o)
	endif

or something like that?

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Git for Windows" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.