Re: [PATCH v5] MinGW(-W64) compilation

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 8, 2014, 19:23 UTC
Message-ID: <xmqqh9ze9xhp.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1412791267-13356-1-git-send-email-marat@slonopotamus.org>

Marat Radchenko <marat@slonopotamus.org> writes:

> This patch series fixes building on modern MinGW and MinGW-W64 (including x86_64).

As Dscho explained in a sub-thread, I really do not want to bypass msysgit folks when dealing with things that relate to Windows, for at least two reasons:

 * I can be a patch monkey and apply them to my tree but then I
   would be pushing out changes that I didn't try out myself
   otherwise.  Granted, that is true for platforms other than
   Windows that I do not regularly build and test on, but when I
   know there are capable folks who have been working on Windows
   issues for a long time, not asking for their help does not make
   much sense.

 * They still have other changes that are yet to be fed to my tree,
   and I do not actively track and compare their tree.  A patch
   series prepared against my tree may collide with their ongoing
   effort to make Git on Windows platform better and risk making
   more work for them, not less.

The earlier part of your series (including the ones that were Acked by EFL) looked sensible to me: 1-6, 9, 11, 12 (outside compat/ part only).

I could take them directly to my tree, but that is still on "as long as msysgit folks are OK with them" basis.

Thanks.

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Git for Windows" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.