Re: [PATCH 07/14] Fix BASIC_LDFLAGS and COMPAT_CFLAGS for 64bit MinGW-w64
- From
Ray Donnelly <mingw.android@gmail.com>
- Date
- Oct 9, 2014, 23:56 UTC
- Message-ID
- <CAOYw7dtouon0EXYQPnvpc7ZMARKwaureNTK6ZL+aByknpPG-9A@mail.gmail.com>
- In-Reply-To
- <alpine.DEB.1.00.1410092146310.990@s15462909.onlinehome-server.info>
Thanks Johannes.
On Thu, Oct 9, 2014 at 8:47 PM, Johannes Schindelin < Johannes.Schindelin@gmx.de> wrote:
Show 10 quoted lines
> Hi Ray, > > On Thu, 9 Oct 2014, Ray Donnelly wrote: > >> On Thu, Oct 9, 2014 at 8:22 PM, Johannes Schindelin >> <Johannes.Schindelin@gmx.de> wrote: >> > >> > On Wed, 8 Oct 2014, Marat Radchenko wrote: >> > >> >> +CC_MACH := $(shell sh -c '$(CC) -dumpmachine 2>/dev/null || echo
not')
Show 18 quoted lines
>> > >> > There is a rather huge problem with that. The latest mingw-w64 >> > release, 4.9.1, does not do what you expect here: while >> > '.../mingw32/bin/gcc -m32 -o 32.exe test.c' and '.../mingw32/bin/gcc >> > -m64 -o 64.exe test.c' work fine, producing i686 and x86_64 >> > executables respectively, '.../mingw32/bin/gcc -dumpmachine' prints >> > i686-w64-mingw32 *always*, even when specifying the -m64 option. >> > >> > So unfortunately, the test introduced by this patch (intended to >> > figure out whether the build targets i686, and skip a compiler and a >> > linker option otherwise) is incorrect. >> >> Which release are you talking about? Can you point me to the tarball >> please? > > Certainly: > >
http://sourceforge.net/projects/mingw-w64/files/Toolchains%20targetting%20Win32/Personal%20Builds/mingw-builds/4.9.1/threads-win32/sjlj/
> > (rev1, not rev0)
I guess I can add passing in CFLAGS also to try to catch that case. What would you recommend?
I've added support to build using your branch to MSYS2's MINGW-packages git-git package in case anyone wants to help out:
https://github.com/Alexpux/MINGW-packages/tree/master/mingw-w64-git-git
Change _based_on_dscho_w64_msysgit=no to =yes. Note also that some more patches are needed before we can build, and I think more are needed. Using plain msysGit (I.e. =no) and 15 patches we are able to build a somewhat functional git.
> > Ciao, > Johannes
-- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "Git for Windows" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.