git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 11/14] compat/nedmalloc/malloc.c.h: fix compilation under MinGW-W64

From
Marat Radchenko <marat@slonopotamus.org>
Date
Oct 8, 2014, 18:01 UTC
Message-ID
<1412791267-13356-12-git-send-email-marat@slonopotamus.org>
In-Reply-To
<1412791267-13356-1-git-send-email-marat@slonopotamus.org>
1. Unlike MinGW, MinGW-W64 already provides _ReadWriteBarrier macro,
   so don't try to redefine it.
2. MinGW-W64 has a strange definition FORCEINLINE as
   extern __inline__ __attribute__((__always_inline__,__gnu_inline__))
   'extern' doesn't work together with 'static', so #undef MinGW-W64
   version of FORCEINLINE.
Signed-off-by: Marat Radchenko <marat@slonopotamus.org>
---
 compat/nedmalloc/malloc.c.h | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/compat/nedmalloc/malloc.c.h b/compat/nedmalloc/malloc.c.h
index f216a2a..a6c8cac 100644
--- a/compat/nedmalloc/malloc.c.h
+++ b/compat/nedmalloc/malloc.c.h
@@ -715,6 +715,10 @@ struct mallinfo {
 #endif /* HAVE_USR_INCLUDE_MALLOC_H */
 #endif /* NO_MALLINFO */
 
+#ifdef __MINGW64_VERSION_MAJOR
+  #undef FORCEINLINE
+#endif
+
 /*
   Try to persuade compilers to inline. The most critical functions for
   inlining are defined as macros, so these aren't used for them.
@@ -1382,7 +1386,9 @@ LONG __cdecl _InterlockedExchange(LONG volatile *Target, LONG Value);
 
   /*** Atomic operations ***/
   #if (__GNUC__ * 10000 + __GNUC_MINOR__ * 100 + __GNUC_PATCHLEVEL__) > 40100
-    #define _ReadWriteBarrier() __sync_synchronize()
+    #ifndef _ReadWriteBarrier
+      #define _ReadWriteBarrier() __sync_synchronize()
+    #endif
   #else
     static __inline__ __attribute__((always_inline)) long __sync_lock_test_and_set(volatile long * const Target, const long Value)
     {
-- 
2.1.1

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Git for Windows" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Previous: Junio C HamanoNext: Marat Radchenko
Message 24 of 45 in “MinGW(-W64) compilation”
  1. MinGW(-W64) compilationMarat Radchenko, Oct 8, 2014
  2. 01/14 MINGW: compat/mingw.h: do not attempt to redefine lseek on mingw-w64Marat Radchenko, Oct 8, 2014
  3. Erik Faye-LundOct 9, 2014
  4. 02/14 MSVC: config.mak.uname: drop -D__USE_MINGW_ACCESS from CFLAGSMarat Radchenko, Oct 8, 2014
  5. 03/14 MINGW: compat/mingw.h: drop fork() definitionMarat Radchenko, Oct 8, 2014
  6. 04/14 MINGW: do not fail at redefining pid_t on MinGW-W64Marat Radchenko, Oct 8, 2014
  7. 05/14 MINGW: config.mak.uname: allow using cURL for non-msysGit buildsMarat Radchenko, Oct 8, 2014
  8. 06/14 MINGW: compat/winansi.c: do not redefine CONSOLE_FONT_INFOEXMarat Radchenko, Oct 8, 2014
  9. 07/14 Fix BASIC_LDFLAGS and COMPAT_CFLAGS for 64bit MinGW-w64Marat Radchenko, Oct 8, 2014
  10. Junio C HamanoOct 8, 2014
  11. Johannes SchindelinOct 9, 2014
  12. Ray DonnellyOct 9, 2014
  13. Johannes SchindelinOct 9, 2014
  14. Ray DonnellyOct 9, 2014
  15. Johannes SchindelinOct 10, 2014
  16. Johannes SchindelinOct 10, 2014
  17. Johannes SchindelinOct 11, 2014
  18. Marat RadchenkoOct 14, 2014
  19. 08/14 MINGW: git-compat-util.h: use inttypes.h for printf macrosMarat Radchenko, Oct 8, 2014
  20. Junio C HamanoOct 8, 2014
  21. 09/14 MINGW: config.mak.uname: reorganize MinGW settingsMarat Radchenko, Oct 8, 2014
  22. 10/14 Makefile: introduce CROSS_COMPILE variableMarat Radchenko, Oct 8, 2014
  23. Junio C HamanoOct 8, 2014
  24. 11/14 compat/nedmalloc/malloc.c.h: fix compilation under MinGW-W64Marat Radchenko, Oct 8, 2014
  25. 12/14 Fix pointer -> integer casts on IL32P64 systemsMarat Radchenko, Oct 8, 2014
  26. 13/14 git-compat-util.h: fix integer overflow on IL32P64 systemsMarat Radchenko, Oct 8, 2014
  27. Junio C HamanoOct 8, 2014
  28. Junio C HamanoOct 8, 2014
  29. Marat RadchenkoOct 9, 2014
  30. Junio C HamanoOct 9, 2014
  31. Johannes SchindelinOct 9, 2014
  32. 14/14 MINGW: config.mak.uname: auto-detect MinGW build from compilerMarat Radchenko, Oct 8, 2014
  33. Junio C HamanoOct 8, 2014
  34. Marat RadchenkoOct 9, 2014
  35. Johannes SchindelinOct 9, 2014
  36. Junio C HamanoOct 9, 2014
  37. Johannes SchindelinOct 9, 2014
  38. Marat RadchenkoOct 9, 2014
  39. Junio C HamanoOct 8, 2014
  40. Johannes SchindelinOct 9, 2014
  41. Marat RadchenkoOct 9, 2014
  42. Johannes SchindelinOct 9, 2014
  43. Johannes SchindelinOct 9, 2014
  44. Johannes SchindelinOct 9, 2014
  45. Johannes SchindelinOct 11, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.