Re: SHA1 collisions found
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 26, 2017, 18:22 UTC
- Message-ID
- <xmqqzih8yfpd.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20170226004657.zowlojdzqrrcalsm@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 9 quoted lines
> On Sat, Feb 25, 2017 at 11:35:27PM +0100, Lars Schneider wrote: > ... >> That's a good idea! I wonder if it would make sense to setup an >> additional job in TravisCI that patches every Git version with some hash >> collisions and then runs special tests. > > I think it would be interesting to see the results under various > scenarios. I don't know that it would be all that interesting from an > ongoing CI perspective.
I had the same thought.
I view such a test as a very good validation while we are finishing up the introduction of new hash and the update to the codepaths that need to handle both hashes, so I'd expect such a test to be a good validation measure. But once that work is concluded, I do not know if tests in ongoing basis is all that interesting.