Re: [PATCH 1/3] add collision-detecting sha1 implementation
- From
Jeff King <peff@peff.net>
- Date
- Feb 24, 2017, 00:16 UTC
- Message-ID
- <20170224001602.vks3lvbrbarcccmk@sigill.intra.peff.net>
- In-Reply-To
- <CA+55aFx4gXEXqr-z12E4gz5fm2fye-vVio_Td7EbKxymGF2QUw@mail.gmail.com>
On Thu, Feb 23, 2017 at 04:12:01PM -0800, Linus Torvalds wrote:
Show 10 quoted lines
> On Thu, Feb 23, 2017 at 4:01 PM, Jeff King <peff@peff.net> wrote: > > > > You know, I didn't even look at the LICENSE file, since it said MIT and > > had a link here. It would be trivial to copy it over, too, of course. > > You should do it. It's just good to be careful and clear with > licenses, and the license text does require that the copyright notice > and permission file should be included in copies. > > My patch did it. "Pats self on head".
And that's why yours crossed the 100K barrier. :)
But yeah, I agree it is better to be safe (and that's we should contact the authors). I'll point them out-of-band to this thread, and cc them if it ends up being re-rolled.
-Peff