Re: [PATCH] git-contacts: Add recognition of Reported-by

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 24, 2017, 19:29 UTC
Message-ID: <xmqqzibtd473.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170724183103.b4vbr5xkijj7s7z3@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 13 quoted lines

>> I also should have mentioned the need for a way to say "remove all
>> hardcoded default and start from scratch".
>
> There's already some prior art around trailers in the trailer.* config.
> I wonder if it would make sense to claim a new key there, like:
>
>   git config trailer.Reported-by.autocc true
>
> If "Reported-by" is a trailer that your project uses, then there may be
> some benefit to setting up other config related to it, and this would
> mesh nicely. And then potentially other programs besides git-contacts
> would want to respect that flag (perhaps send-email would even want to
> do it itself; I think it already respects cc and s-o-b headers).

Sounds like a good suggestion.  But...

If I understand your proposal, the trailer stuff would still not care what value .autocc is set to while doing its own thing, but the programs that read the text file that the trailer can work on would pay attention to it, and they individually have to do so? Perhaps there is a need for another mode "interpret-trailers" is told to run in, where it is given a text file with trailers in it and is told to show only the value that has .autocc bit on? Alternatively, yield <key, value> pairs so that the user of the tool can further process the value differently depending on the key, or something?