Re: [PATCH] git-contacts: Add recognition of Reported-by

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 21, 2017, 14:37 UTC
Message-ID: <xmqqbmodj1pa.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170721141530.25907-1-eblake@redhat.com>

Eric Blake <eblake@redhat.com> writes:

Show 6 quoted lines

> It's nice to cc someone that reported a bug, in order to let
> them know that a fix is being considered, and possibly even
> get their help in reviewing/testing the patch.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---

I don't know if this new one deserves to be part of the hardcoded defaults; it would be different between the projects and depends on their convention. I notice that there is no way to configure this script and I suspect that it would be a more generally useful update to have it read a configuration variable that lists what kind of sob like things to take addresses from.

Thanks.

Show 16 quoted lines

>  contrib/contacts/git-contacts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/contacts/git-contacts b/contrib/contacts/git-contacts
> index dbe2abf27..85ad732fc 100755
> --- a/contrib/contacts/git-contacts
> +++ b/contrib/contacts/git-contacts
> @@ -11,7 +11,7 @@ use IPC::Open2;
>
>  my $since = '5-years-ago';
>  my $min_percent = 10;
> -my $labels_rx = qr/Signed-off-by|Reviewed-by|Acked-by|Cc/i;
> +my $labels_rx = qr/Signed-off-by|Reviewed-by|Acked-by|Cc|Reported-by/i;
>  my %seen;
>
>  sub format_contact {