Re: [PATCH] git-contacts: Add recognition of Reported-by

From: Jeff King <peff@peff.net>
Date: Jul 24, 2017, 18:31 UTC
Message-ID: <20170724183103.b4vbr5xkijj7s7z3@sigill.intra.peff.net>
In-Reply-To: <xmqqwp71hj5n.fsf@gitster.mtv.corp.google.com>

On Fri, Jul 21, 2017 at 09:03:16AM -0700, Junio C Hamano wrote:

Show 20 quoted lines

> Eric Blake <eblake@redhat.com> writes:
> 
> > You mean, something like
> >
> > git config --add contacts.autocc Reported-by
> > git config --add contacts.autocc Suggested-by
> >
> > where contacts.autocc would be a new multi-valued config option
> > specifying additional Tag: patterns to scrape out of the commit message?
> 
> Yes, something along that line, and you are correct to point out
> that I should have mentioned the need for command-line override.
> 
> In fact, if you anticipate that the primary use of this contributed
> script is as "send-email --cccmd", then we probably are better off
> doing this without any configuration variables, but just add the
> mechanism for command-line override of the hardcoded default.
> 
> I also should have mentioned the need for a way to say "remove all
> hardcoded default and start from scratch".

There's already some prior art around trailers in the trailer.* config. I wonder if it would make sense to claim a new key there, like:

  git config trailer.Reported-by.autocc true

If "Reported-by" is a trailer that your project uses, then there may be some benefit to setting up other config related to it, and this would mesh nicely. And then potentially other programs besides git-contacts would want to respect that flag (perhaps send-email would even want to do it itself; I think it already respects cc and s-o-b headers).

-Peff