Re: [PATCH] git-contacts: Add recognition of Reported-by
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 27, 2017, 16:45 UTC
- Message-ID
- <xmqqh8xxomka.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20170724193651.ocup4b6cs5hqmstx@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 19 quoted lines
> Yeah, I don't think interpret-trailers is currently a useful tool for > looking at an extra config key like that. I'd expect it would need to be > extended, or a new tool added, or perhaps existing tools would need to > learn more about how trailers work (e.g., it would be nice if git-log > could do matching or even print them via %(trailer:reported-by) > placeholders or something). I think there's a lot of potential work in > that area. > > Of course git-contacts (or send-email) _can_ just look look at all of > the trailer.*.autocc config and try to match those manually. But the > point of having trailer config, I think, is that we should stop doing > ad-hoc parsing and have a tool for manipulating and querying trailers. > If interpret-trailers isn't up to the task yet, I'd rather see work go > there. > > But that (manual parsing) is basically how the current cc and s-o-b > trailers implemented inside of git-send-email, so I don't think it would > be the end of the world as a quick hack that could later be expanded to > use the trailer infrastructure.
OK.
In any case, I think not CC'ing the reporter would be a bug, and an update to the "contacts" script (in contrib/) to use an improved convention and interpret-trailers tool can be built on top of the version Eric posted, so let's take the patch anyway for now.
Thanks.