git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] http: handle curl with vendor backports

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 20, 2017, 16:28 UTC
Message-ID
<xmqqziau6w63.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20170820084725.ce5inn5jzkyor4zk@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 31 quoted lines
> On Fri, Aug 11, 2017 at 03:15:06PM -0700, Junio C Hamano wrote:
>
>> "Tom G. Christensen" <tgc@jupiterrise.com> writes:
>> 
>> > The curl packages provided by Red Hat for RHEL contain several
>> > backports of features from later curl releases.
>> > This causes problems with current version based checks in http.c.
>> >
>> > Here is an overview of the features that have been backported:
>> > 7.10.6 (el3) Backports CURLPROTO_*
>> > 7.12.1 (el4) Backports CURLPROTO_*
>> > 7.15.5 (el5) Backports GSSAPI_DELEGATION_*
>> >              Backports CURLPROTO_*
>> > 7.19.7 (el6) Backports GSSAPI_DELEGATION_*
>> >              Backports CURL_SSL_VERSION_TLSv1_{0,1,2}
>> > 7.29.0 (el7) Backports CURL_SSL_VERSION_TLSv1_{0,1,2}
>> >
>> > This patch series will update the current version based checks for
>> > protocol restriction and GSSAPI delegation control support to ones
>> > based on features to properly deal with the above listed backports.
>> > The fine grained TLS version support does not seem to be
>> > distinguishable via a preprocessor macro so I've left that alone.
>> 
>> Thanks; these feature macros ought to be more dependable, and I
>> think this moves things in the right direction (regardless of which
>> features we might later pick as mandatory and cut off supports for
>> older versions).
>
> Yes, I agree that these are an improvement regardless. If we follow
> through on the cut-off to 7.19.4, then the CURLPROTO ones all go away.
> But I don't mind rebasing any cut-off proposal on top of this work.

Yeah I came to a similar conclusion and was about asking if you feel the same way that your series should be made on top of Tom's fixes.

The aspect of that series I do like the most is to base our decisions on features, not versions, and I also wonder if we can do similar in your "abandon too old ones" series, too.

Thanks.
Previous: Jeff KingNext: Jeff King
Message 10 of 11 in “http: handle curl with vendor backports”
  1. 0/2 http: handle curl with vendor backportsTom G. Christensen, Aug 11, 2017
  2. 2/2 http: use a feature check to enable GSSAPI delegation controlTom G. Christensen, Aug 11, 2017
  3. 1/2 http: Fix handling of missing CURLPROTO_*Tom G. Christensen, Aug 11, 2017
  4. Junio C HamanoAug 12, 2017
  5. Tom G. ChristensenAug 12, 2017
  6. Jeff KingAug 20, 2017
  7. Junio C HamanoAug 11, 2017
  8. Tom G. ChristensenAug 12, 2017
  9. Jeff KingAug 20, 2017
  10. Junio C HamanoAug 20, 2017
  11. Jeff KingAug 23, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.