[PATCH 1/2] http: Fix handling of missing CURLPROTO_*
- From
Tom G. Christensen <tgc@jupiterrise.com>
- Date
- Aug 11, 2017, 16:37 UTC
- Message-ID
- <4d29d43d458f61c6dabca093f591ad8698ca2ceb.1502462884.git.tgc@jupiterrise.com>
- In-Reply-To
- <cover.1502462884.git.tgc@jupiterrise.com>
Commit aeae4db1 refactored the handling of the curl protocol restriction support into a function but failed to add a version check for older versions of curl that lack CURLPROTO_* support. This adds the missing check and at the same time converts it to a feature check instead of a version based check. This is done to ensure that vendor supported curl versions that have had CURLPROTO_* support backported are handled correctly.
Signed-off-by: Tom G. Christensen <tgc@jupiterrise.com> --- http.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/http.c b/http.c index e00264cff..569909e8a 100644 --- a/http.c +++ b/http.c @@ -685,6 +685,7 @@ void setup_curl_trace(CURL *handle) curl_easy_setopt(handle, CURLOPT_DEBUGDATA, NULL); } +#ifdef CURLPROTO_HTTP static long get_curl_allowed_protocols(int from_user) { long allowed_protocols = 0; @@ -700,6 +701,7 @@ static long get_curl_allowed_protocols(int from_user) return allowed_protocols; } +#endif static CURL *get_curl_handle(void) { @@ -798,7 +800,7 @@ static CURL *get_curl_handle(void) #elif LIBCURL_VERSION_NUM >= 0x071101 curl_easy_setopt(result, CURLOPT_POST301, 1); #endif -#if LIBCURL_VERSION_NUM >= 0x071304 +#ifdef CURLPROTO_HTTP curl_easy_setopt(result, CURLOPT_REDIR_PROTOCOLS, get_curl_allowed_protocols(0)); curl_easy_setopt(result, CURLOPT_PROTOCOLS,
-- 2.14.1