Re: [PATCH 0/2] http: handle curl with vendor backports
- From
Jeff King <peff@peff.net>
- Date
- Aug 20, 2017, 08:47 UTC
- Message-ID
- <20170820084725.ce5inn5jzkyor4zk@sigill.intra.peff.net>
- In-Reply-To
- <xmqq1sohzr85.fsf@gitster.mtv.corp.google.com>
On Fri, Aug 11, 2017 at 03:15:06PM -0700, Junio C Hamano wrote:
Show 25 quoted lines
> "Tom G. Christensen" <tgc@jupiterrise.com> writes:
>
> > The curl packages provided by Red Hat for RHEL contain several
> > backports of features from later curl releases.
> > This causes problems with current version based checks in http.c.
> >
> > Here is an overview of the features that have been backported:
> > 7.10.6 (el3) Backports CURLPROTO_*
> > 7.12.1 (el4) Backports CURLPROTO_*
> > 7.15.5 (el5) Backports GSSAPI_DELEGATION_*
> > Backports CURLPROTO_*
> > 7.19.7 (el6) Backports GSSAPI_DELEGATION_*
> > Backports CURL_SSL_VERSION_TLSv1_{0,1,2}
> > 7.29.0 (el7) Backports CURL_SSL_VERSION_TLSv1_{0,1,2}
> >
> > This patch series will update the current version based checks for
> > protocol restriction and GSSAPI delegation control support to ones
> > based on features to properly deal with the above listed backports.
> > The fine grained TLS version support does not seem to be
> > distinguishable via a preprocessor macro so I've left that alone.
>
> Thanks; these feature macros ought to be more dependable, and I
> think this moves things in the right direction (regardless of which
> features we might later pick as mandatory and cut off supports for
> older versions).Yes, I agree that these are an improvement regardless. If we follow through on the cut-off to 7.19.4, then the CURLPROTO ones all go away. But I don't mind rebasing any cut-off proposal on top of this work.
-Peff