git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] http: use a feature check to enable GSSAPI delegation control

From
Tom G. Christensen <tgc@jupiterrise.com>
Date
Aug 11, 2017, 16:37 UTC
Message-ID
<b037d7116bb6eac965a5cba2357611b156c07b8d.1502462884.git.tgc@jupiterrise.com>
In-Reply-To
<cover.1502462884.git.tgc@jupiterrise.com>

Turn the version check into a feature check to ensure this functionality is also enabled with vendor supported curl versions where the feature may have been backported.

Signed-off-by: Tom G. Christensen <tgc@jupiterrise.com>
---
 http.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/http.c b/http.c
index 569909e8a..a3ae58f13 100644
--- a/http.c
+++ b/http.c
@@ -91,7 +91,7 @@ static struct {
 	 * here, too
 	 */
 };
-#if LIBCURL_VERSION_NUM >= 0x071600
+#ifdef CURLGSSAPI_DELEGATION_FLAG
 static const char *curl_deleg;
 static struct {
 	const char *name;
@@ -356,7 +356,7 @@ static int http_options(const char *var, const char *value, void *cb)
 	}
 
 	if (!strcmp("http.delegation", var)) {
-#if LIBCURL_VERSION_NUM >= 0x071600
+#ifdef CURLGSSAPI_DELEGATION_FLAG
 		return git_config_string(&curl_deleg, var, value);
 #else
 		warning(_("Delegation control is not supported with cURL < 7.22.0"));
@@ -727,7 +727,7 @@ static CURL *get_curl_handle(void)
 	curl_easy_setopt(result, CURLOPT_HTTPAUTH, CURLAUTH_ANY);
 #endif
 
-#if LIBCURL_VERSION_NUM >= 0x071600
+#ifdef CURLGSSAPI_DELEGATION_FLAG
 	if (curl_deleg) {
 		int i;
 		for (i = 0; i < ARRAY_SIZE(curl_deleg_levels); i++) {
-- 
2.14.1
Previous: Tom G. ChristensenNext: Tom G. Christensen
Message 2 of 11 in “http: handle curl with vendor backports”
  1. 0/2 http: handle curl with vendor backportsTom G. Christensen, Aug 11, 2017
  2. 2/2 http: use a feature check to enable GSSAPI delegation controlTom G. Christensen, Aug 11, 2017
  3. 1/2 http: Fix handling of missing CURLPROTO_*Tom G. Christensen, Aug 11, 2017
  4. Junio C HamanoAug 12, 2017
  5. Tom G. ChristensenAug 12, 2017
  6. Jeff KingAug 20, 2017
  7. Junio C HamanoAug 11, 2017
  8. Tom G. ChristensenAug 12, 2017
  9. Jeff KingAug 20, 2017
  10. Junio C HamanoAug 20, 2017
  11. Jeff KingAug 23, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.