Re: [PATCH] gitk: expand $config_file_tmp before reporting to user

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 28, 2017, 22:03 UTC
Message-ID: <xmqqzi9ezdk4.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <alpine.DEB.2.21.1.1709281428170.40514@virtualbox>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 12 quoted lines

>> > Max Kirillov <max@max630.net> writes:
>> >
>> >> Tilda-based path may confise some users. First, tilda is not known
>> >> for Window users, second, it may point to unexpected location
>> >> depending on various environment setup.
> ...
> As familiar, as it is unfamiliar to Windows users.
>
> So I would actually suggest to make this a conditional on the platform: on
> Windows, use the native name, everywhere else, not.
>
> Sound good?

Not really.

I agree with and (more importantly) consider the second rationale Max cites a more relevant one for this change.

This is about reporting an error, and using the short-hand ~/$rest that could be pointing at a location different from what the user _thinks_ it points at for whatever reason (miconfigured HOME, some intermediate process setting it to something else, etc.) can hide the real issue. The problem can be more easily noticed and diagnosed if the message shows the result of 'nativename'.

And that rationale holds whether you are seeing the error message on Windows or non-Windows.