Re: [PATCH] gitk: expand $config_file_tmp before reporting to user

From: Max Kirillov <max@max630.net>
Date: Sep 29, 2017, 04:34 UTC
Message-ID: <20170929043406.GA9325@jessie.local>
In-Reply-To: <alpine.DEB.2.21.1.1709281428170.40514@virtualbox>

On Thu, Sep 28, 2017 at 02:31:17PM +0200, Johannes Schindelin wrote:

Show 8 quoted lines

>>> Max Kirillov <max@max630.net> writes:
>>>> Tilda-based path may confise some users. First, tilda is not known
>>>> for Window users, second, it may point to unexpected location
>>>> depending on various environment setup.
>>>>
>>>> Expand the path to "nativename", so that ~/.config/git/gitk-tmp
>>>> would be "C:\Users\user\.config\git\gitk-tmp", for example.
>>>> It should be less cryptic

> Thanks, Max, for your contribution!

I do what I can. Just noticed s question at SO about it (https://stackoverflow.com/questions/46450479/how-to-remove-the-stale-gitk-tmp-file) Provided that I was author of the message, it looked like something for me to fix.

> Sound good?

As Junio noticed, it would be more reliable to show full path, and error message does not have to be very nice anyway. Also, gitk is already too big and I always feel bad when adding stuff to it, so let's save couple of lines by not adding another "if".

-- 
Max