Re: [PATCH] gitk: expand $config_file_tmp before reporting to user
- From
- Uxío Prego <uprego@madiva.com>
- Date
- Sep 29, 2017, 20:24 UTC
- Message-ID
- <544DEAEA-9F66-471A-BEC9-B3D1F3C475AD@madiva.com>
- In-Reply-To
- <xmqq4lrn30bz.fsf@gitster.mtv.corp.google.com>
Well something like this is not paying _Paul_ enough for what he gave to The People, so I do not think there is worth trying.
Show 25 quoted lines
> On 28 Sep 2017, at 06:37, Junio C Hamano <gitster@pobox.com> wrote:
>
> Max Kirillov <max@max630.net> writes:
>
>> Tilda-based path may confise some users. First, tilda is not known
>> for Window users, second, it may point to unexpected location
>> depending on various environment setup.
>>
>> Expand the path to "nativename", so that ~/.config/git/gitk-tmp
>> would be "C:\Users\user\.config\git\gitk-tmp", for example.
>> It should be less cryptic
>
> It might be less cryptic, but for those of us whose $HOME is a
> looooooong path, ~/.config/git/gitk-tmp is much easier to understand
> than the same path with ~/ expanded, which would push the part of
> the filename that most matters far to the right hand side of the
> dialog.
>
> I somehow find this change just robbing Peter to pay Paul.
>
>> } else {
>> - error_popup "There appears to be a stale $config_file_tmp\
>> + error_popup "There appears to be a stale \
>> + \"[file nativename $config_file_tmp]\" \
>