git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitk: expand $config_file_tmp before reporting to user

From
Max Kirillov <max@max630.net>
Date
Sep 28, 2017, 04:14 UTC
Message-ID
<20170928041417.28947-1-max@max630.net>

Tilda-based path may confise some users. First, tilda is not known for Window users, second, it may point to unexpected location depending on various environment setup.

Expand the path to "nativename", so that ~/.config/git/gitk-tmp would be "C:\Users\user\.config\git\gitk-tmp", for example. It should be less cryptic

Signed-off-by: Max Kirillov <max@max630.net>
---
 gitk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gitk b/gitk
index 877d49e1de..48c1d3e714 100755
--- a/gitk
+++ b/gitk
@@ -2844,7 +2844,8 @@ proc config_check_tmp_exists {tries_left} {
 	if {$tries_left > 0} {
 	    after 100 [list config_check_tmp_exists $tries_left]
 	} else {
-	    error_popup "There appears to be a stale $config_file_tmp\
+	    error_popup "There appears to be a stale \
+ \"[file nativename $config_file_tmp]\" \
  file, which will prevent gitk from saving its configuration on exit.\
  Please remove it if it is not being used by any existing gitk process."
 	}
-- 
2.11.0.1122.gc3fec58.dirty
Next: Junio C Hamano
Message 1 of 7 in “gitk: expand $config_file_tmp before reporting to user”
  1. gitk: expand $config_file_tmp before reporting to userMax Kirillov, Sep 28, 2017
  2. Junio C HamanoSep 28, 2017
  3. Junio C HamanoSep 28, 2017
  4. Johannes SchindelinSep 28, 2017
  5. Junio C HamanoSep 28, 2017
  6. Max KirillovSep 29, 2017
  7. Uxío PregoSep 29, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.