Re: [PATCH v5 1/9] Start to implement a built-in version of `git add --interactive`

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 13, 2019, 14:01 UTC
Message-ID: <xmqqzhgzan9l.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <nycvar.QRO.7.76.6.1911131326300.46@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 5 quoted lines

>> As I do not see those past '--helper' ones necessarily successes, we
>> must agree to disagree here.
>
> Right. But if I recall, you never even saw the need for the conversions
> in the first place. Maybe you still don't?

You probably are forgetting the fact that I was very supportive for the rewrite of checkout, commit and format-patch (the last one being my favorite) in C from scripted Porcelain.

None of these were '--helper' style conversion and I would consider them much more successful than the recent ones, some of which still suffer from impedance mismatch bugs (e.g. some parts of the C implementation work on the in-core index, while other parts working on the on the on-disk index, letting them become out of sync and introducing bugs).