Re: [PATCH v3 06/11] built-in add -i: implement the main loop
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 31, 2019, 18:14 UTC
- Message-ID
- <xmqqo91aoyu9.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <175409aaae0f3127b92126dc201faa4b41da0870.1563289115.git.gitgitgadget@gmail.com>
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:
> The Perl script `git-add--interactive.perl` mixed the purposes of the > "list" and the "and choose" part into the same function. In the C > version, we will keep them separate instead, calling the `list()` > function from the `list_and_choose()` function.
Makes sense. After all, I recall writing "add -i" in a few iterations of lunch-time hack. If we are to rewrite it from scratch, we should engineer it the right way ;-)