Re: [PATCH v3 01/11] Start to implement a built-in version of `git add --interactive`

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 28, 2019, 15:37 UTC
Message-ID: <xmqqd0gp1etv.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <nycvar.QRO.7.76.6.1908281705230.46@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 15 quoted lines

>> Ah, so "add.usebuiltin = interactive patch" can (eventually) choose
>> to use the C code for both while "add.usebuiltin = interactive"
>> would not use it for the patch mode, or something?  Or even
>>
>> 	add.interactive.usebuiltin = yes
>
> This is what I had in mind.
>
>> 	add.patch.usebuiltin = no
>
> And this is what I should have done ;-)
>
> But maybe I should do
>
> 	add.useBuiltin = wheneverPossible

Ah, either is fine, I think, but because this is meant to be temporary and not advertised to end-users for purposes other than purely an escape hatch, I would not spend too much engineering effort (iow, do the easiest to add and then easiest to later yank out).

Thanks.