git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] notes.c: fix a segfault in notes_display_config()

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 23, 2020, 06:59 UTC
Message-ID
<xmqqzh38o8x8.fsf@gitster.c.googlers.com>
In-Reply-To
<20201123032342.24566-2-nate@roosteregg.cc>
nate@roosteregg.cc writes:
>  	if (*load_refs && !strcmp(k, "notes.displayref")) {
>  		if (!v)
> -			config_error_nonbool(k);
> +			return config_error_nonbool(k);

"git grep config_error_nonbool" tells us that this is the only instance that ignores the return value from the function and does not cause the caller to die.

Looks good.  Thanks.
Previous: nate@roosteregg.ccNext: nate@roosteregg.cc
Message 3 of 5 in “Fix a segfault in git log --notes”
  1. 0/2 Fix a segfault in git log --notesnate@roosteregg.cc, Nov 23, 2020
  2. 1/2 notes.c: fix a segfault in notes_display_config()nate@roosteregg.cc, Nov 23, 2020
  3. Junio C HamanoNov 23, 2020
  4. 2/2 t3301: test proper exit response to no-value notes.displayRef.nate@roosteregg.cc, Nov 23, 2020
  5. Junio C HamanoNov 23, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.