From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 23 Nov 2020 06:59:31 GMT
Subject: Re: [PATCH 1/2] notes.c: fix a segfault in notes_display_config()
Message-ID: <xmqqzh38o8x8.fsf@gitster.c.googlers.com>
In-Reply-To: <20201123032342.24566-2-nate@roosteregg.cc>

nate@roosteregg.cc writes:

>  	if (*load_refs && !strcmp(k, "notes.displayref")) {
>  		if (!v)
> -			config_error_nonbool(k);
> +			return config_error_nonbool(k);

"git grep config_error_nonbool" tells us that this is the only
instance that ignores the return value from the function and does
not cause the caller to die.

Looks good.  Thanks.