git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] Fix a segfault in git log --notes

From
nate@roosteregg.cc <nate@roosteregg.cc>
Date
Nov 23, 2020, 03:23 UTC
Message-ID
<20201123032342.24566-1-nate@roosteregg.cc>
From: Nate Avers <nate@roosteregg.cc>
Hi,

I came across a segfault in git log --notes (also affects diff-tree) when notes.displayRef is configured with no value (not an empty value). It appears to stem from a missing return statement in notes.c:notes_display_config(). Very small fix. (Not sure how much sense it makes to include the test.)

Thanks, Nate

Nate Avers (2):
  notes.c: fix a segfault in notes_display_config()
  t3301: test proper exit response to no-value notes.displayRef.
 notes.c          | 2 +-
 t/t3301-notes.sh | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)
-- 
2.27.0
Next: nate@roosteregg.cc
Message 1 of 5 in “Fix a segfault in git log --notes”
  1. 0/2 Fix a segfault in git log --notesnate@roosteregg.cc, Nov 23, 2020
  2. 1/2 notes.c: fix a segfault in notes_display_config()nate@roosteregg.cc, Nov 23, 2020
  3. Junio C HamanoNov 23, 2020
  4. 2/2 t3301: test proper exit response to no-value notes.displayRef.nate@roosteregg.cc, Nov 23, 2020
  5. Junio C HamanoNov 23, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.