git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] t3301: test proper exit response to no-value notes.displayRef.

From
nate@roosteregg.cc <nate@roosteregg.cc>
Date
Nov 23, 2020, 03:23 UTC
Message-ID
<20201123032342.24566-3-nate@roosteregg.cc>
In-Reply-To
<20201123032342.24566-1-nate@roosteregg.cc>
From: Nate Avers <nate@roosteregg.cc>
Signed-off-by: Nate Avers <nate@roosteregg.cc>
---
 t/t3301-notes.sh | 5 +++++
 1 file changed, 5 insertions(+)
diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh
index 8f43303007..ca60faf480 100755
--- a/t/t3301-notes.sh
+++ b/t/t3301-notes.sh
@@ -672,6 +672,11 @@ test_expect_success 'notes.displayRef respects order' '
 	test_cmp expect-both-reversed actual
 '
 
+test_expect_success 'notes.displayRef with no value handled gracefully' '
+	test_must_fail git -c notes.displayRef log -0 --notes &&
+	test_must_fail git -c notes.displayRef diff-tree --notes HEAD
+'
+
 test_expect_success 'GIT_NOTES_DISPLAY_REF works' '
 	GIT_NOTES_DISPLAY_REF=refs/notes/commits:refs/notes/other \
 		git log -2 >actual &&
-- 
2.27.0
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 5 in “Fix a segfault in git log --notes”
  1. 0/2 Fix a segfault in git log --notesnate@roosteregg.cc, Nov 23, 2020
  2. 1/2 notes.c: fix a segfault in notes_display_config()nate@roosteregg.cc, Nov 23, 2020
  3. Junio C HamanoNov 23, 2020
  4. 2/2 t3301: test proper exit response to no-value notes.displayRef.nate@roosteregg.cc, Nov 23, 2020
  5. Junio C HamanoNov 23, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.