Re: [PATCH v2 0/2] Add new "signature" atom

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 2, 2023, 07:29 UTC
Message-ID: <xmqqzg5i8gpt.fsf@gitster.g>
In-Reply-To: <20230602023105.17979-1-five231003@gmail.com>

Kousik Sanagavarapu <five231003@gmail.com> writes:

> I have also rebased this to be on top of v2.41.0, the previous version
> was on top of v2.41.0-rc0.

I am still feverish and feeling weak so no real review from me yet, but there is one thing that immediately jumped at me.

Show 9 quoted lines

> Range-diff against v1:
>
> 1:  5c97d11b79 ! 1:  87465ef1a8 t/lib-gpg: introduce new prereq GPG2
>     @@ t/lib-gpg.sh: test_lazy_prereq GPG '
>      +  test $? != 127 || exit 1
>      +
>      +  case "$gpg_version" in
>     -+  !"gpg (GnuPG) 2."*)
>     ++  "gpg (GnuPG) 0."* | "gpg (GnuPG) 1.*")

The last '*' being inside double-quote would not be what you intended, I suspect?