Re: [PATCH v2 0/2] Add new "signature" atom

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 3, 2023, 00:16 UTC
Message-ID: <xmqqilc58kn9.fsf@gitster.g>
In-Reply-To: <CAPig+cRmY3oDJLVKsBgKVZc-bJ7hArzk2eib9Ra5timC=Xz_kA@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 7 quoted lines

> Moreover, I wondered if using `[01]` to avoid the repetition would be
> worthwhile:
>
>     case "$gpg_version" in
>     "gpg (GnuPG) "[01].*)
>
> though, of course, it's subjective whether that is clearer.

Excellent.

I'd say that the value of your version is primarily that it is much less error prone than repeating the constant string part that can be misspelt. The glob limiting "begins with either '0' or '1' followed by a dot" might be slightly less easier to understand for less trained eyes, but eyes will not remain untrained forever, so it is OK.