Re: [PATCH v2 1/2] t/lib-gpg: introduce new prereq GPG2

From: Kousik Sanagavarapu <five231003@gmail.com>
Date: Jun 2, 2023, 12:58 UTC
Message-ID: <ZHnnZ_plMZ-wdO4M@fivlite-virtual-machine>
In-Reply-To: <CAP8UFD2wcnNaihGv=SQ_77OLQ5PN3DG73rnh2F_C_j+BFTcCyw@mail.gmail.com>

On Fri, Jun 02, 2023 at 08:50:18AM +0200, Christian Couder wrote:

Show 14 quoted lines

> On Fri, Jun 2, 2023 at 4:31 AM Kousik Sanagavarapu <five231003@gmail.com> wrote:
> 
> > +test_lazy_prereq GPG2 '
> > +       gpg_version=$(gpg --version 2>&1)
> > +       test $? != 127 || exit 1
> > +
> > +       case "$gpg_version" in
> > +       "gpg (GnuPG) 0."* | "gpg (GnuPG) 1.*")
> 
> s/"gpg (GnuPG) 1.*"/"gpg (GnuPG) 1."*/
> 
> I am not sure if it changes anything, but for testing if we have v0
> here and v1.0.6 in the "test_lazy_prereq PGP", we put the '*'
> character outside the double quoted string.

It does seem that it changes things, thanks for catching. I'll reroll with the necessary changes (there are also some style issues that Oswald pointed out).

Thanks