Re: [PATCH v3 1/3] t/lib-httpd: dynamically detect httpd and modules path

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 9, 2023, 07:46 UTC
Message-ID: <xmqqzfzn1i9u.fsf@gitster.g>
In-Reply-To: <ZUyMFZ7c9_rlu5lk@tanuki>

Patrick Steinhardt <ps@pks.im> writes:

Show 5 quoted lines

> Yeah, I was grepping for it in our codebase and saw other occurrences,
> so I assumed it was fair game. If we're going to convert it to the
> below, how about I send another patch on top that also converts the
> preexisting instances so that the next one grepping for it isn't going
> to repeat the same mistake?

Yup, an independent clean-up would be fine. Now we need to find a way to give better visibility to CodingGuidelines, which already says this:

 - We do not write our "test" command with "-a" and "-o" and use "&&"
   or "||" to concatenate multiple "test" commands instead, because
   the use of "-a/-o" is often error-prone.  E.g.

     test -n "$x" -a "$a" = "$b"

   is buggy and breaks when $x is "=", but

     test -n "$x" && test "$a" = "$b"

   does not have such a problem.