Re: [PATCH v3 3/3] t9164: fix inability to find basename(1) in Subversion hooks

From: Jeff King <peff@peff.net>
Date: Nov 9, 2023, 07:35 UTC
Message-ID: <20231109073517.GB2698227@coredump.intra.peff.net>
In-Reply-To: <6891e2541552073c6827d81d2b761252f253bea2.1699513524.git.ps@pks.im>

On Thu, Nov 09, 2023 at 08:10:01AM +0100, Patrick Steinhardt wrote:

Show 6 quoted lines

> +	# Subversion hooks run with an empty environment by default. We thus
> +	# need to propagate PATH so that we can find executables.
> +	cat >"$rawsvnrepo/conf/hooks-env" <<-EOF
> +	[default]
> +	PATH = ${PATH}
> +	EOF

This is so much less ugly than the shell shenanigans discussed in the earlier round. Thanks for finding it. :)

The ${PATH} here is interpolated by the here-doc. I guess it's possible somebody's exotic PATH could break the svn conf syntax, but it's probably not worth worrying about.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.