Re: [PATCH v3 0/3] t: improve compatibility with NixOS

From: Jeff King <peff@peff.net>
Date: Nov 9, 2023, 07:36 UTC
Message-ID: <20231109073615.GC2698227@coredump.intra.peff.net>
In-Reply-To: <cover.1699513524.git.ps@pks.im>

On Thu, Nov 09, 2023 at 08:09:47AM +0100, Patrick Steinhardt wrote:

Show 16 quoted lines

> this is the third version of my patch series to improve compatibility of
> our tests with NixOS.
> 
> Changes compared to v2:
> 
>     - Patch 1: We now check for both httpd and apache2 binaries via
>       PATH.
> 
>     - Patch 1: We're a bit more defensive and will check whether
>       variables are empty before passing them to either `test -d` or
>       `test -x`.
> 
>     - Patch 3: Clarified why PATH is unset.
> 
>     - Patch 3: Instead of writing PATH into the hook we now write it
>       into the `hook-env` configuration file read by Subversion.

Thanks. This looks good to me, modulo a minor shell nit I mentioned in the first patch.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.