Re: [PATCH v4 0/3] t: improve compatibility with NixOS

From: Jeff King <peff@peff.net>
Date: Nov 10, 2023, 21:41 UTC
Message-ID: <20231110214126.GB2758295@coredump.intra.peff.net>
In-Reply-To: <cover.1699596457.git.ps@pks.im>

On Fri, Nov 10, 2023 at 09:16:56AM +0100, Patrick Steinhardt wrote:

Show 13 quoted lines

> this is the fourth version of my patch series to improve compatibility
> of our test suite with NixOS.
> 
> Three changes compared to v3:
> 
>     - Switched from `test <expr> -a <expr>` to `test <expr> && test
>       <expr>`.
> 
>     - Improved the commit message to explain why the new
>       runtime-detected paths are only used as a fallback.
> 
>     - Rebased on top of 0e3b67e2aa (ci: add support for GitLab CI,
>       2023-11-09), which has been merged to `next` and caused conflicts.

Thanks, these all look good to me.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.