git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t3429: use test_path_is_file helper

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 22, 2026, 14:48 UTC
Message-ID
<xmqqzew5iyej.fsf@gitster.g>
In-Reply-To
<CAPSxiM9SuRiRA6Xixp_zx=fFf_a6S8Mp327FP82Pg7mJdzQ3Kw@mail.gmail.com>
Usman Akinyemi <usmanakinyemi202@gmail.com> writes:
Show 13 quoted lines
> On Wed, Oct 21, 2026 at 12:30 PM Joy via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>>
>> From: Joy Gundu <soniqjjj@gmail.com>
>>
>> Signed-off-by: Joy Gundu <soniqjjj@gmail.com>
>> ---
>>     t3429: use test_path_is_file helper
>>
>>     Replace test -e F with test_path_is_file F in t3429-rebase-edit-todo.sh
>>     to use Git's semantic test helper and provide better diagnostics on
> Why is the commit message down after the dashes, isn't is supposed to
> be at the top?

(tip: leave a blank line between what they write and what you write, both before and after)

It is a common mistake of GGG users. When they write an empty commit message and then elaborate in the pull request message, we see something like what we are looking at.

Show 13 quoted lines
>>         todo=.git/rebase-merge/git-rebase-todo &&
>>         git rebase HEAD~1 -x "echo exec touch F >>$todo" &&
>> -       test -e F
>> +       test_path_is_file F
> This is wrong, the initial patch is testing whether "F" exists, not whether
> it is a file. The appropriate function to use here is test_patch_exists.
>>  '
>>
>>  test_expect_success 'rebase exec with an empty list does not exec anything' '
>>
>> base-commit: c51408889c3b372814bc20b9431c3b74d0d268eb
>> --
>> gitgitgadget
Previous: Usman Akinyemi
Message 3 of 3 in “t3429: use test_path_is_file helper”
  1. t3429: use test_path_is_file helperJoy via GitGitGadget, Oct 21, 2026
  2. Usman AkinyemiOct 22, 2026
  3. Junio C HamanoOct 22, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.