git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t3429: use test_path_is_file helper

From
JGJoy via GitGitGadget <gitgitgadget@gmail.com>
Date
Oct 21, 2026, 11:30 UTC
Message-ID
<pull.2274.git.1792582249420.gitgitgadget@gmail.com>
From: Joy Gundu <soniqjjj@gmail.com>
Signed-off-by: Joy Gundu <soniqjjj@gmail.com>
---
    t3429: use test_path_is_file helper
    
    Replace test -e F with test_path_is_file F in t3429-rebase-edit-todo.sh
    to use Git's semantic test helper and provide better diagnostics on
    failure.
    
    Tested with:
    
    make NO_ICONV=YesPlease test T=t3429-rebase-edit-todo.sh
    
    All 7 tests passed.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2274%2FJoiejoie1%2Foutreachy%2Ftest-path-helper-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2274/Joiejoie1/outreachy/test-path-helper-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2274
 t/t3429-rebase-edit-todo.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t3429-rebase-edit-todo.sh b/t/t3429-rebase-edit-todo.sh
index 28e4bdd0d9..a421c35d8a 100755
--- a/t/t3429-rebase-edit-todo.sh
+++ b/t/t3429-rebase-edit-todo.sh
@@ -14,7 +14,7 @@ test_expect_success 'setup' '
 test_expect_success 'rebase exec modifies rebase-todo' '
 	todo=.git/rebase-merge/git-rebase-todo &&
 	git rebase HEAD~1 -x "echo exec touch F >>$todo" &&
-	test -e F
+	test_path_is_file F
 '
 
 test_expect_success 'rebase exec with an empty list does not exec anything' '

base-commit: c51408889c3b372814bc20b9431c3b74d0d268eb
-- 
gitgitgadget
Next: Usman Akinyemi
Message 1 of 3 in “t3429: use test_path_is_file helper”
  1. t3429: use test_path_is_file helperJoy via GitGitGadget, Oct 21, 2026
  2. Usman AkinyemiOct 22, 2026
  3. Junio C HamanoOct 22, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.