From: Junio C Hamano Date: Thu, 22 Oct 2026 14:48:52 GMT Subject: Re: [PATCH] t3429: use test_path_is_file helper Message-ID: In-Reply-To: Usman Akinyemi writes: > On Wed, Oct 21, 2026 at 12:30 PM Joy via GitGitGadget > wrote: >> >> From: Joy Gundu >> >> Signed-off-by: Joy Gundu >> --- >> t3429: use test_path_is_file helper >> >> Replace test -e F with test_path_is_file F in t3429-rebase-edit-todo.sh >> to use Git's semantic test helper and provide better diagnostics on > Why is the commit message down after the dashes, isn't is supposed to > be at the top? (tip: leave a blank line between what they write and what you write, both before and after) It is a common mistake of GGG users. When they write an empty commit message and then elaborate in the pull request message, we see something like what we are looking at. >> todo=.git/rebase-merge/git-rebase-todo && >> git rebase HEAD~1 -x "echo exec touch F >>$todo" && >> - test -e F >> + test_path_is_file F > This is wrong, the initial patch is testing whether "F" exists, not whether > it is a file. The appropriate function to use here is test_patch_exists. >> ' >> >> test_expect_success 'rebase exec with an empty list does not exec anything' ' >> >> base-commit: c51408889c3b372814bc20b9431c3b74d0d268eb >> -- >> gitgitgadget