Re: [PATCH] t3429: use test_path_is_file helper
On Wed, Oct 21, 2026 at 12:30 PM Joy via GitGitGadget <gitgitgadget@gmail.com> wrote:
Show 9 quoted lines
>
> From: Joy Gundu <soniqjjj@gmail.com>
>
> Signed-off-by: Joy Gundu <soniqjjj@gmail.com>
> ---
> t3429: use test_path_is_file helper
>
> Replace test -e F with test_path_is_file F in t3429-rebase-edit-todo.sh
> to use Git's semantic test helper and provide better diagnostics on
Why is the commit message down after the dashes, isn't is supposed to be at the top?
> todo=.git/rebase-merge/git-rebase-todo &&
> git rebase HEAD~1 -x "echo exec touch F >>$todo" &&
> - test -e F
> + test_path_is_file F
This is wrong, the initial patch is testing whether "F" exists, not whether it is a file. The appropriate function to use here is test_patch_exists.
Show 7 quoted lines
> '
>
> test_expect_success 'rebase exec with an empty list does not exec anything' '
>
> base-commit: c51408889c3b372814bc20b9431c3b74d0d268eb
> --
> gitgitgadget