Re: [PATCH 6/7] pack-protocol.txt: Mark pushee field as optional

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 1, 2015, 19:07 UTC
Message-ID: <xmqqy4iz8zon.fsf@gitster.dls.corp.google.com>
In-Reply-To: <xmqqbnfvaeqk.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 16 quoted lines

> Dave Borowitz <dborowitz@google.com> writes:
>
>> send-pack.c omits this field when args->url is null or empty. Fix the
>> protocol specification to match reality.
>
> Do some clients omit this in the real world?
>
> As you say, send_pack() does omit it if args->url is null or empty,
> but args is prepared in transport.c as a copy of transport->url when
> the function is called, and that transport->url is how
> builtin/push.c reports where it is pushing with:
>
>    if (verbosity > 0)
>        fprintf(stderr, _("Pushing to %s\n"), transport->url);
>
> So I am somewhat puzzled...

Answering myself, the most trivial example is "git send-pack" ;-) It passes args that has a NULL in the .url field.