Re: [PATCH 6/7] pack-protocol.txt: Mark pushee field as optional
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 1, 2015, 18:56 UTC
- Message-ID
- <xmqqbnfvaeqk.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <1435774099-21260-7-git-send-email-dborowitz@google.com>
Dave Borowitz <dborowitz@google.com> writes:
> send-pack.c omits this field when args->url is null or empty. Fix the > protocol specification to match reality.
Do some clients omit this in the real world?
As you say, send_pack() does omit it if args->url is null or empty, but args is prepared in transport.c as a copy of transport->url when the function is called, and that transport->url is how builtin/push.c reports where it is pushing with:
if (verbosity > 0)
fprintf(stderr, _("Pushing to %s\n"), transport->url);So I am somewhat puzzled...
Show 29 quoted lines
>
> Signed-off-by: Dave Borowitz <dborowitz@google.com>
> ---
> Documentation/technical/pack-protocol.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/technical/pack-protocol.txt b/Documentation/technical/pack-protocol.txt
> index f37dcf1..98e512d 100644
> --- a/Documentation/technical/pack-protocol.txt
> +++ b/Documentation/technical/pack-protocol.txt
> @@ -495,7 +495,7 @@ references.
> push-cert = PKT-LINE("push-cert" NUL capability-list LF)
> PKT-LINE("certificate version 0.1" LF)
> PKT-LINE("pusher" SP push-cert-ident LF)
> - PKT-LINE("pushee" SP url LF)
> + [PKT-LINE("pushee" SP url LF)]
> PKT-LINE("nonce" SP nonce LF)
> PKT-LINE(LF)
> *PKT-LINE(command LF)
> @@ -554,7 +554,8 @@ Currently, the following header fields are defined:
> `pushee` url::
> The repository URL (anonymized, if the URL contains
> authentication material) the user who ran `git push`
> - intended to push into.
> + intended to push into. This field is optional, and included at
> + the client's discretion.
>
> `nonce` nonce::
> The 'nonce' string the receiving repository asked the