Re: [PATCH 3/7] pack-protocol.txt: Mark all LFs in push-cert as required
- From
Jeff King <peff@peff.net>
- Date
- Jul 3, 2015, 18:46 UTC
- Message-ID
- <20150703184608.GA11526@peff.net>
- In-Reply-To
- <CAJo=hJsoKSB23KNNF9Xr-NUAqUXvq+O-ZYOSyb4wAC1TZKZ2-g@mail.gmail.com>
On Fri, Jul 03, 2015 at 11:43:33AM -0700, Shawn Pearce wrote:
Show 5 quoted lines
> > For (2), hopefully we can implement it in the same way, and rely on > > empty sideband-0 packets. I haven't tested it in practice, though (I > > have some very rough patches for (1) already). > > sideband-0 is not going to work for JGit clients.
Er, sorry, mental hiccup. It is 0-length sideband-1 packets that I meant. The same as for upload-pack keepalives.
> JGit clients are strict about the sideband stream being 1,2,3 and fail > hard if they get any other stream from the server[1].
I think git does, too.
-Peff