Re: [PATCH 3/7] pack-protocol.txt: Mark all LFs in push-cert as required

From: Shawn Pearce <spearce@spearce.org>
Date: Jul 6, 2015, 15:46 UTC
Message-ID: <CAJo=hJvfYfgBthFMYXnXJ6e6PVM92SsWGVNt7qNTSQH9=psGtQ@mail.gmail.com>
In-Reply-To: <xmqqzj3f7gde.fsf@gitster.dls.corp.google.com>

On Wed, Jul 1, 2015 at 1:49 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

> Dave Borowitz <dborowitz@google.com> writes:
>
>>> I am moderately negative about this; wouldn't it make the end result
>>> cleaner to fix the implementation?
>>
>> I'm not sure I understand your suggestion. Are you saying, you would
>> prefer to make LFs optional in the push cert, for consistency with LFs
>> being optional elsewhere?
>
> Absolutely.  It is not "make" it optional, but "even though it is
> optional, the receiver has not been following the spec, and it is
> not too late to fix it".

This is madness. For all the reasons Dave points out later in the thread. You can't store and make sense of the push cert without the LF record delimiters.

push cert format is like commit or tag format. You need those LFs. We can't just go declare them optional because of the way pkt-line read function is implemented in git-core.