Re: [PATCH] transport, send-pack: append period to up-to-date message

From: Junio C Hamano <gitster@pobox.com>
Date: May 25, 2016, 22:55 UTC
Message-ID: <xmqqy46xycg0.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160525224733.GF13776@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I think messages to stderr are generally fair game for changing, even in
> plumbing. In many cases they are also translated (and I would argue that
> these messages probably should be translated, too).

I think I agree. My first reaction to this thread indeed was "Why isn't this marked for translation?"; as to the change proposed by the patch itself, my reaction actually was "Meh" ;-)

> That being said, CodingGuidelines says:
>
>    - Do not end error messages with a full stop.

Thanks for pointing it out---I forgot about that one.

I do not think there was a concrete reason why they should not end with a full stop, other than "be consistent with existing ones that do not end with a full stop", though.

> This isn't an error message exactly, but I think it's in the same vein.
> I will note that we have not historically been consistent here, though
> (as evidenced by the noted message in git-merge).