Re: [PATCH] transport, send-pack: append period to up-to-date message

From: Stefan Beller <sbeller@google.com>
Date: May 24, 2016, 21:21 UTC
Message-ID: <CAGZ79kayB59-U52oAw=13a2CAhJLsfmoD6JbAURbt0p8g8a8fg@mail.gmail.com>
In-Reply-To: <1464123104-45513-1-git-send-email-junk@humanoriented.com>

On Tue, May 24, 2016 at 1:51 PM, Yong Bakos <junk@humanoriented.com> wrote:

Show 13 quoted lines

> Appending a period to "Everything up-to-date" makes the output message
> consistent with similar output in builtin/merge.c.
>
> Signed-off-by: Yong Bakos <ybakos@humanoriented.com>
> ---
>  builtin/send-pack.c | 2 +-
>  transport.c         | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/builtin/send-pack.c b/builtin/send-pack.c
> index 1ff5a67..67d9304 100644
> --- a/builtin/send-pack.c
> +++ b/builtin/send-pack.c

While consistency is a good idea in general, I wonder how that applies here. git-send-pack is a low level (i.e. plumbing) command.

       The interface (input, output, set of options and the semantics) to
       these low-level commands are meant to be a lot more stable than
       Porcelain level commands, because these commands are primarily for
       scripted use. The interface to Porcelain commands on the other hand are
       subject to change in order to improve the end user experience.

So if another porcelain exists and compares the output string exactly, this would be a regression for them. That is why I'd refrain from updating these strings

However these two strings are only showing up in these 2 places, so maybe instead we'd want to see a test documenting existing behavior?

Thanks, Stefan