Re: [PATCH] transport, send-pack: append period to up-to-date message

From: Yong Bakos <junk@humanoriented.com>
Date: May 26, 2016, 14:16 UTC
Message-ID: <AD23EFA5-FE44-4CE8-AD95-D95300E05B55@humanoriented.com>
In-Reply-To: <xmqqy46xycg0.fsf@gitster.mtv.corp.google.com>

On May 25, 2016, at 5:55 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> 
> Jeff King <peff@peff.net> writes:
> 
>> I think messages to stderr are generally fair game for changing, even in
>> plumbing. In many cases they are also translated (and I would argue that
>> these messages probably should be translated, too).
> 
> I think I agree.  My first reaction to this thread indeed was "Why
> isn't this marked for translation?"; as to the change proposed by
> the patch itself, my reaction actually was "Meh" ;-)

Aw come one, Junio, you mean one "." doesn't excite you? :)

Show 14 quoted lines

> 
>> That being said, CodingGuidelines says:
>> 
>>   - Do not end error messages with a full stop.
> 
> Thanks for pointing it out---I forgot about that one.
> 
> I do not think there was a concrete reason why they should not end
> with a full stop, other than "be consistent with existing ones that
> do not end with a full stop", though.
> 
>> This isn't an error message exactly, but I think it's in the same vein.
>> I will note that we have not historically been consistent here, though
>> (as evidenced by the noted message in git-merge).

Indeed, most of the output during a pull/merge/push workflow breaks the "don't end with a full stop" guideline. I believe that this patch, despite its candidacy for the "most insignificant patch award," is a sane one.

Thanks for reviewing, yong