git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] transport, send-pack: append period to up-to-date message

From
Jeff King <peff@peff.net>
Date
May 25, 2016, 22:47 UTC
Message-ID
<20160525224733.GF13776@sigill.intra.peff.net>
In-Reply-To
<CAGZ79kayB59-U52oAw=13a2CAhJLsfmoD6JbAURbt0p8g8a8fg@mail.gmail.com>
On Tue, May 24, 2016 at 02:21:00PM -0700, Stefan Beller wrote:
Show 27 quoted lines
> On Tue, May 24, 2016 at 1:51 PM, Yong Bakos <junk@humanoriented.com> wrote:
> > Appending a period to "Everything up-to-date" makes the output message
> > consistent with similar output in builtin/merge.c.
> >
> > Signed-off-by: Yong Bakos <ybakos@humanoriented.com>
> > ---
> >  builtin/send-pack.c | 2 +-
> >  transport.c         | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/builtin/send-pack.c b/builtin/send-pack.c
> > index 1ff5a67..67d9304 100644
> > --- a/builtin/send-pack.c
> > +++ b/builtin/send-pack.c
> 
> While consistency is a good idea in general, I wonder how that applies here.
> git-send-pack is a low level (i.e. plumbing) command.
> 
>        The interface (input, output, set of options and the semantics) to
>        these low-level commands are meant to be a lot more stable than
>        Porcelain level commands, because these commands are primarily for
>        scripted use. The interface to Porcelain commands on the other hand are
>        subject to change in order to improve the end user experience.
> 
> So if another porcelain exists and compares the output string
> exactly, this would be a regression for them. That is why I'd refrain
> from updating these strings

I think messages to stderr are generally fair game for changing, even in plumbing. In many cases they are also translated (and I would argue that these messages probably should be translated, too).

That being said, CodingGuidelines says:
   - Do not end error messages with a full stop.

This isn't an error message exactly, but I think it's in the same vein. I will note that we have not historically been consistent here, though (as evidenced by the noted message in git-merge).

-Peff
Previous: Stefan BellerNext: Junio C Hamano
Message 3 of 5 in “transport, send-pack: append period to up-to-date message”
  1. transport, send-pack: append period to up-to-date messageYong Bakos, May 24, 2016
  2. Stefan BellerMay 24, 2016
  3. Jeff KingMay 25, 2016
  4. Junio C HamanoMay 25, 2016
  5. Yong BakosMay 26, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.