Re: [PATCH v2] t/Makefile: add a rule to re-run previously-failed tests

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 8, 2016, 20:34 UTC
Message-ID: <xmqqy432f7wl.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <alpine.DEB.2.20.1609020933430.129229@virtualbox>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 9 quoted lines

> On Thu, 1 Sep 2016, Junio C Hamano wrote:
>
>> Hopefully that [patch removing the -<pid> suffix] would help making
>> Dscho's "what are the failed tests?" logic simpler.
>
> Of course.
>
> It also makes sure that those 2 hours I spent on writing and perfecting
> the sed magic were spent in vain... ;-)

Well it is either

 * the sed magic is so arcane that you'd need to spend a long time,
   comparable to 2 hours you already spent, if you ever need to look
   at it and figure out what it does next time you need to change
   something in it.

or

 * you are not familiar with the sed magic and you would be able to
   write the same thing in 2 minutes next time if you need to adjust
   it when we add -pid back later.

Either way, those 2 hours are not wasted.

I personally fall into the former category. Any sed script that needs G, h, and x together I need to spend at least 15 minutes just to warm myself up, as I do not work with the language that often.

Thanks ;-)