Re: [PATCH v2] t/Makefile: add a rule to re-run previously-failed tests

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 31, 2016, 10:36 UTC
Message-ID: <alpine.DEB.2.20.1608311233440.129229@virtualbox>
In-Reply-To: <xmqq37lm3w6u.fsf@gitster.mtv.corp.google.com>

Hi,

[Sverre: we are considering to remove the -<pid> suffix in test-results/, see more below.]

On Tue, 30 Aug 2016, Junio C Hamano wrote:

Show 11 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > Hmm, interesting. Your approach seems reasonable, but I have to wonder
> > if writing the pid in the first place is sane.
> >
> > I started to write up my reasoning in this email, but realized it was
> > rapidly becoming the content of a commit message. So here is that
> > commit.
> 
> Sounds sensible; if this makes Dscho's "which ones failed in the
> previous run" simpler, that is even better ;-)

I did not have the time to dig further before now. There must have been a good reason why we append the PID.

Sverre, you added that code in 2d84e9f (Modify test-lib.sh to output stats to t/test-results/*, 2008-06-08): any idea why the -<pid> suffix was needed?

Ciao, Dscho