git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t/Makefile: add a rule to re-run previously-failed tests

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jun 29, 2016, 07:02 UTC
Message-ID
<b2d016e44fa04e8a318967c43762d6933faf7956.1467183740.git.johannes.schindelin@gmx.de>

While developing patch series, it is a good practice to run the test suite from time to time, just to make sure that obvious bugs are caught early. With complex patch series, it is common to run `make -j15 -k test`, i.e. run the tests in parallel and not stop at the first failing test but continue. This has the advantage of identifying possibly multiple problems without having to wait for the complete test suite to finish.

It is particularly important to reduce the turn-around time thusly on Windows, where the test suite spends 45 minutes on the computer on which this patch was developed.

It is the most convenient way to determine which tests failed after running the entire test suite, in parallel, to look for left-over "trash directory.t*" subdirectories in the t/ subdirectory.

This patch automates the process of determinig which tests failed previously and re-running them; It turned out to be quite convenient when trying to squash bugs that crept in during rebases.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
Published-As: https://github.com/dscho/git/releases/tag/failing-tests-v1
 t/Makefile | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/t/Makefile b/t/Makefile
index 18e2b28..1459a7f 100644
--- a/t/Makefile
+++ b/t/Makefile
@@ -35,6 +35,8 @@ all: $(DEFAULT_TEST_TARGET)
 test: pre-clean $(TEST_LINT)
 	$(MAKE) aggregate-results-and-cleanup
 
+failed: $(patsubst trash,,$(patsubst directory.%,%.sh,$(wildcard trash\ directory.t[0-9]*)))
+
 prove: pre-clean $(TEST_LINT)
 	@echo "*** prove ***"; $(PROVE) --exec '$(SHELL_PATH_SQ)' $(GIT_PROVE_OPTS) $(T) :: $(GIT_TEST_OPTS)
 	$(MAKE) clean-except-prove-cache
-- 
2.9.0.118.g0e1a633

base-commit: cf4c2cfe52be5bd973a4838f73a35d3959ce2f43
Next: Junio C Hamano
Message 1 of 32 in “t/Makefile: add a rule to re-run previously-failed tests”
  1. t/Makefile: add a rule to re-run previously-failed testsJohannes Schindelin, Jun 29, 2016
  2. Junio C HamanoJun 29, 2016
  3. Johannes SchindelinJul 1, 2016
  4. Jeff KingJun 30, 2016
  5. Johannes SchindelinJul 1, 2016
  6. t/Makefile: add a rule to re-run previously-failed testsJohannes Schindelin, Aug 29, 2016
  7. Jeff KingAug 30, 2016
  8. Junio C HamanoAug 30, 2016
  9. Johannes SchindelinAug 31, 2016
  10. Sverre RabbelierSep 1, 2016
  11. Johannes SchindelinSep 1, 2016
  12. Sverre RabbelierSep 1, 2016
  13. Junio C HamanoSep 1, 2016
  14. Johannes SchindelinSep 2, 2016
  15. Junio C HamanoSep 8, 2016
  16. Ævar Arnfjörð BjarmasonAug 30, 2016
  17. Jeff KingAug 30, 2016
  18. Ævar Arnfjörð BjarmasonAug 30, 2016
  19. Johannes SchindelinAug 31, 2016
  20. Ævar Arnfjörð BjarmasonAug 31, 2016
  21. Johannes SchindelinAug 31, 2016
  22. Ævar Arnfjörð BjarmasonSep 2, 2016
  23. Johannes SchindelinSep 2, 2016
  24. Matthieu MoySep 2, 2016
  25. Johannes SchindelinSep 4, 2016
  26. Matthieu MoySep 4, 2016
  27. t/Makefile: add a rule to re-run previously-failed testsJohannes Schindelin, Jan 27, 2017
  28. Jeff KingJan 27, 2017
  29. Johannes SchindelinJan 27, 2017
  30. t/Makefile: add a rule to re-run previously-failed testsJohannes Schindelin, Jan 27, 2017
  31. Junio C HamanoJan 27, 2017
  32. Johannes SchindelinJan 30, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.