git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] t/Makefile: add a rule to re-run previously-failed tests

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Sep 4, 2016, 09:19 UTC
Message-ID
<vpqoa44xbs8.fsf@anie.imag.fr>
In-Reply-To
<alpine.DEB.2.20.1609040952110.129229@virtualbox>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 35 quoted lines
> Hi,
>
> On Fri, 2 Sep 2016, Matthieu Moy wrote:
>
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> 
>> > Hi Ævar,
>> >
>> > On Fri, 2 Sep 2016, Ævar Arnfjörð Bjarmason wrote:
>> >
>> >> This might be me missing the point, and I'm really just trying to be
>> >> helpful here and make "prove" work for you because it's awesome, but
>> >> as far as just you running this for development purposes does any of
>> >> this SVN stuff matter? I.e. you can build Git itself not with
>> >> Strawberry, but just use Strawberry to get a working copy of "prove".
>> >
>> > Yes, the SVN stuff matters, because of the many t9*svn* tests (which, BTW
>> > take a substantial time to run). So if I run the test suite, I better do
>> > it with a perl.exe in the PATH that can run the SVN tests. Otherwise I
>> > might just as well not bother with running the entire test suite...
>> 
>> Maybe something like
>> 
>> \path\to\strawberry-perl\perl.exe \path\to\prove ...
>> 
>> without changing the PATH would work. I wouldn't call that convenient
>> though.
>
> Wouldn't Perl-specific environment variables set by Strawberry Perl (such
> as PERL_PATH bleed through to the spawned child processes?
>
> We're dancing around the issue, really. Rather than piling workaround on
> workaround with no end in sight, I think it is time to admit that using
> prove(1) on Windows is just not a good solution for the problem to re-run
> failed tests.

I didn't re-add Ævar's disclaimer, but my message was really not intended to be an objection to your patch, just a (not necessarily good) idea in case you or someone else on windows wanted to give one more chance to prove.

I'm all for adding "make failed". Actually, we could even make the feature more discoverable by echoing "You may run 'make failed' to re-run failed tests" at the end of the tests when one of them failed.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 26 of 32 in “t/Makefile: add a rule to re-run previously-failed tests”
  1. t/Makefile: add a rule to re-run previously-failed testsJohannes Schindelin, Jun 29, 2016
  2. Junio C HamanoJun 29, 2016
  3. Johannes SchindelinJul 1, 2016
  4. Jeff KingJun 30, 2016
  5. Johannes SchindelinJul 1, 2016
  6. t/Makefile: add a rule to re-run previously-failed testsJohannes Schindelin, Aug 29, 2016
  7. Jeff KingAug 30, 2016
  8. Junio C HamanoAug 30, 2016
  9. Johannes SchindelinAug 31, 2016
  10. Sverre RabbelierSep 1, 2016
  11. Johannes SchindelinSep 1, 2016
  12. Sverre RabbelierSep 1, 2016
  13. Junio C HamanoSep 1, 2016
  14. Johannes SchindelinSep 2, 2016
  15. Junio C HamanoSep 8, 2016
  16. Ævar Arnfjörð BjarmasonAug 30, 2016
  17. Jeff KingAug 30, 2016
  18. Ævar Arnfjörð BjarmasonAug 30, 2016
  19. Johannes SchindelinAug 31, 2016
  20. Ævar Arnfjörð BjarmasonAug 31, 2016
  21. Johannes SchindelinAug 31, 2016
  22. Ævar Arnfjörð BjarmasonSep 2, 2016
  23. Johannes SchindelinSep 2, 2016
  24. Matthieu MoySep 2, 2016
  25. Johannes SchindelinSep 4, 2016
  26. Matthieu MoySep 4, 2016
  27. t/Makefile: add a rule to re-run previously-failed testsJohannes Schindelin, Jan 27, 2017
  28. Jeff KingJan 27, 2017
  29. Johannes SchindelinJan 27, 2017
  30. t/Makefile: add a rule to re-run previously-failed testsJohannes Schindelin, Jan 27, 2017
  31. Junio C HamanoJan 27, 2017
  32. Johannes SchindelinJan 30, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.